Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Downgrade.yml #255

Merged
merged 13 commits into from
Jan 8, 2024
Merged

Add Downgrade.yml #255

merged 13 commits into from
Jan 8, 2024

Conversation

sumiya11
Copy link
Collaborator

@sumiya11
Copy link
Collaborator Author

sumiya11 commented Dec 11, 2023

As I understand, we should bump Nemo.jl versions to 0.32-0.38 in StructuralIdentifiability.jl ?

https://github.com/SciML/StructuralIdentifiability.jl/actions/runs/7167680162/job/19514247808#step:5:44

At the moment, ParamPunPam.jl restricts Nemo.jl to 0.32-0.37, and StructuralIdentifiability.jl restricts Nemo.jl to 0.24-0.38. Hence, the lowest possible bound is 0.32

@pogudingleb
Copy link
Collaborator

As I understand, we should bump Nemo.jl versions to 0.32-0.38 in StructuralIdentifiability.jl ?

https://github.com/SciML/StructuralIdentifiability.jl/actions/runs/7167680162/job/19514247808#step:5:44

At the moment, ParamPunPam.jl restricts Nemo.jl to 0.32-0.37, and StructuralIdentifiability.jl restricts Nemo.jl to 0.24-0.38. Hence, the lowest possible bound is 0.32

Yes, I agree 0.32 looks like the lowest feasible

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d71f49) 89.90% compared to head (c3bab78) 89.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files          25       25           
  Lines        3209     3209           
=======================================
  Hits         2885     2885           
  Misses        324      324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sumiya11
Copy link
Collaborator Author

sumiya11 commented Jan 7, 2024

Note for future self: make sure that Groebner.jl v0.6.1 supports Nemo.jl v0.39 (currently v0.6.0 does not https://github.com/sumiya11/Groebner.jl/blob/v0.6.0/Project.toml)

In the light of
#260

@sumiya11
Copy link
Collaborator Author

sumiya11 commented Jan 8, 2024

@pogudingleb thanks for fixing this! I also have this check in Groebner.jl now

@pogudingleb pogudingleb merged commit d97a160 into master Jan 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants